deprecate: deprecate setProfile#144
Merged
Merged
Conversation
Contributor
|
Looks great! Let's merge when tests pass. |
Contributor
|
@cadenmyers13 this is successfully loading |
Contributor
Author
|
@sbillinge ah nice catch, thanks. this is good now |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage 69.36% 69.36%
=======================================
Files 25 25
Lines 3457 3457
=======================================
Hits 2398 2398
Misses 1059 1059
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First shot test following my instructions. everything seemed to work as desired. This will fail until diffpy.utils 3.7.0 is released